Make rspec-rails compatible with Rails v6.1.0.rc2 #2408
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonRowe
reviewed
Dec 3, 2020
| - ruby: ruby-3.0.0-preview1 | ||
| allow_failure: true |
There was a problem hiding this comment.
If we're adding Rails master builds as well as rc builds master should be allowed to fail.
JonRowe
reviewed
Dec 3, 2020
| gsub_file 'spec/support/default_preview_path', | ||
| /ExampleApp/, | ||
| Rails.application.class.parent.to_s | ||
|
|
There was a problem hiding this comment.
I'm convinced these are still needed, its just the Rails 6.1 implementation might need to change?
There was a problem hiding this comment.
I deep dive a little bit on this few weeks ago. The Rails.application.class.parent on previous Rails is ExampleApp. So I didn't understand why the gsub was needed.
Also if the CI pass isn't what we want?
|
Closing as this has been mostly merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add:
Answer: #2398 (comment)