[WiP] Update of requests specs for invalid params for rails 6.1.1 and above

[panSarin]

In order to make requests specs generated for rails 6.1.1 and above
working, we have to update expected behaviour of invalid params for create.

Since rails 6.1.1 is rendering 422 status instead of 302 like before, when
it re-renders form for invalid params, we changed expected behaviour in
request specs.

Also gstubbed files in example app so it will have proper validation
in widget that will be called in generated tests.

Issue related: #2463

[panSarin]

@pirj should I do it this way, or maybe I can just add validation to the widget model in the scaffold generator?

[pirj]

It's quite good like this 👍

[panSarin]

@pirj I started that branch from rails-6-1-dev and since them regardless of CI or what RAILS_VERSION i will set , each time generator is generating rails scaffold for newest version.

def create
    @widget = Widget.new(widget_params)

    respond_to do |format|
      if @widget.save
        format.html { redirect_to @widget, notice: "Widget was successfully created." }
        format.json { render :show, status: :created, location: @widget }
      else
        format.html { render :new, status: :unprocessable_entity }
        format.json { render json: @widget.errors, status: :unprocessable_entity }
      end
    end
  end

That code should only be generated in rails-6.1.1 but it is generated for each CI checks ( same locally ). Any ideas?

[pirj]

It's quite good like this 👍

[pirj]

We're getting there.

  1) /widgets POST /create with invalid parameters renders a successful response (i.e. to display the 'new' template)
     Failure/Error: expect(response).to be_successful
       expected `#<ActionDispatch::TestResponse:0x0000564d388be7d8 @mon_mutex=#<Thread::Mutex:0x0000564d388be788>, @mo..., @method=nil, @request_method=nil, @remote_ip=nil, @original_fullpath=nil, @fullpath=nil, @ip=nil>>.successful?` to be truthy, got false
     # ./spec/requests/widgets_spec.rb:82:in `block (4 levels) in <top (required)>'

  2) /widgets PATCH /update with invalid parameters renders a successful response (i.e. to display the 'edit' template)
     Failure/Error: expect(response).to be_successful
       expected `#<ActionDispatch::TestResponse:0x0000564d38c3deb8 @mon_mutex=#<Thread::Mutex:0x0000564d38c3de68>, @mo..., @method=nil, @request_method=nil, @remote_ip=nil, @original_fullpath=nil, @fullpath=nil, @ip=nil>>.successful?` to be truthy, got false
     # ./spec/requests/widgets_spec.rb:114:in `block (4 levels) in <top (required)>'

I guess this should be

expect(response.status).to redirect_to(:new)

or something?

[pirj]

That's quite odd for a 6.1 build 🤔

   3) /widgets POST /create with invalid parameters renders a response with 422 status - unporcessable entity
     Failure/Error: expect(response.status).to eq(422)

       expected: 422
            got: 302

[pirj]

What if you

export RAILS_VERSION='~> 6.0.0'

then remove your Gemfile.lock and bundle install?

I suggest adding to Gemfile-custom:

gem 'pry-byebug'

Then, you would be able to add binding.pry in lib/generators/rspec/scaffold/templates/request_spec.rb:

<% binding.pry %>
<% if Rails.version.to_f < 6.1 || Rails.version == '6.1.0' %>

and see what Rails.version returns and if this condition is correct.

[panSarin]

Hmm problem with rails version is not in lib/generators/rspec/scaffold/templates/request_spec.rb.
There is rails version taken from RAILS_VERSION (checked it your way, but also errors from previous comments that you mention are specifying that).

Problem is in generated
tmp/example_app/app/controllers/widgets_controller.rb
and
tmp/example_app/app/controllers/tickets_controller.rb
that generates #create method with the 6.1.1 style ( even when rails --version => 6.0.3.5) which is:

def create    
    respond_to do |format|
      if @ticket.save
        format.html { redirect_to @ticket, notice: "Ticket was successfully created." }
        format.json { render :show, status: :created, location: @ticket }
      else
        format.html { render :new, status: :unprocessable_entity }
        format.json { render json: @ticket.errors, status: :unprocessable_entity }
      end
    end
end

and for rails versions lower than 6.1.1 it should be

  # POST /tickets
  def create
    @ticket = Ticket.new(ticket_params)
    if @ticket.save
      redirect_to @ticket, notice: 'Ticket was successfully created.'
    else
      render :new
    end
  end

So I assume there is some issue in changing rails versions in example app generator from newest to the one selected in Gemfile.lock for rspec-rails. Or maybe I am doing something wrong ?

I also checked Gemfile.lock for generated example app - rails is 6.0.3.5. So Gemfile is having proper rails, but generated controller are like for rails 6.1.1 - is there any chance that we run rails scaffold in example_app_generator with newest rails version, not the rails version from project?

Update: it seems like it is also related to ruby version, but i will test it more and review Rails code.

[pirj]

So what Rails.version evaluates to when you're at that breakpoint?

[panSarin]

So what Rails.version evaluates to when you're at that breakpoint?

   120:     context "with invalid parameters" do
   121:     <% byebug %>
=> 122:     <% if Rails.version.to_f < 6.1 || Rails.version == '6.1.0' %>
   123:       it "renders a successful response (i.e. to display the 'edit' template)" do
   124:         <%= file_name %> = <%= class_name %>.create! valid_attributes
   125:         patch <%= show_helper.tr('@', '') %>, params: { <%= singular_table_name %>: invalid_attributes }
   126:         expect(response).to be_successful
(byebug) Rails.version
"6.0.3.5"
(byebug) RUBY_VERSION
"2.7.2"

Funny thing is that i generated new applications for Rails 6.0.3.5 on two other machines, and in one of them there was "new 422" behaviou in generated controller, and in other one "the old one". But there was differences of ruby versions between them. So I will test that on same ruby, and probably report it as Rails issue.