Reduce sandboxing to prevent swallowed deprecations #2857
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
JonRowe
reviewed
Aug 8, 2025
|
I'm on the fence as to which is better, sandboxing examples we know are examples or just everything, but we should at least extend the sandboxed config to not swallow output... |
pirj
force-pushed
the
reduce-sandboxing-to-fix-missed-deprecation-reports
branch
from
3086f85 to
c886a46
Compare
@JonRowe Done |
We used to sandbox everything, but it turns out that deprecations were swallowed, as the temporary config has no deprecation stream set, or stderr is masked.
Alternatively, we can set sandbox_config.deprecation_stream = real_deprecation_stream but this seems unnecessary.
pirj
force-pushed
the
reduce-sandboxing-to-fix-missed-deprecation-reports
branch
from
c886a46 to
3ece04d
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
CI green, @JonRowe how do you feel about this change? |
JonRowe
deleted the
reduce-sandboxing-to-fix-missed-deprecation-reports
branch
|
Thanks for this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We used to sandbox everything, but it turns out that deprecations (
RSpec.deprecate("anything")) were swallowed, as the temporary config has no deprecation stream set, or stderr is masked.Found here #2849 (comment)
We're almost back to square one with deprecations as we were before #2365
However, I'm not entirely happy with this approach. We still mute deprecations for those Rails-related example group specs and a few others, and there are chances deprecations will pop up there eventually.
❓ Would it be better to replay the configuration block on top of the sandboxed configuration? Probably not, and it might not work if stderr is intercepted.
Please consider this WIP