Fix for #360 #362
Fix for #360 #362
Conversation
Otherwise Capybara's includes are not set correctly. Fixes rspec#360
| begin | ||
| require 'webrat' | ||
| rescue LoadError | ||
| end |
There was a problem hiding this comment.
I'd rather keep this ^^ in this file. What about just reversing the inclusion order in rails.rb? Also, I'd like a spec for this to avoid regressions. I'm not sure of the best way to manage that yet. Got any ideas?
There was a problem hiding this comment.
Unfortunately, inclusion order reversal doesn't work (that's the first thing I tried). BrowserSimulators module is used in Example, so it should be required first.
I'll come up with the spec later, but I still can't see a nicer solution. Load capybara from railtie, tied to a proper initializer?
There was a problem hiding this comment.
Unfortunately this breaks capy support in controller, view, and helper specs. Looks like I'm going to need to rethink how/when capy and webrat get loaded.
|
I merged your commit, and then made some further changes in ec15a2f. Let me know if you have any questions. |
No description provided.