Add cuke feature explaining custom routes #651
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| end | ||
|
|
||
| end | ||
| end |
There was a problem hiding this comment.
The output of this would be:
ApplicationController
custom
does not work by default
when custom routes are drawn
works
when a route is drawn with custom parameters
accepts custom parameters
I think it would read better like this (or similar):
a custom route in an anonymous controllers
is not supported by default
with custom routes drawn in the spec
is supported with no params
is supported with custom params
Note that this moves the code in before hooks right into the examples, but that's fine in this case because there is no duplication. WDYT?
|
Looks much better! |
|
Thanks, @pcasaretto. That looks better to me. Cheers. |
|
Merged with ee3f224. I felt like the case where the routing failed was covered by other examples, so I reduced the scenario a bit. Thanks very much @pcasaretto! 🌈 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is related to #636