fix(value_box): Restore full screen functionality #699
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schloerke
approved these changes
Jul 19, 2023
cpsievert
approved these changes
Jul 19, 2023
schloerke
added a commit
to posit-dev/py-shiny
that referenced
this pull request
Jul 19, 2023
schloerke
added a commit
to posit-dev/py-shiny
that referenced
this pull request
Jul 24, 2023
* main: Add E2E tests for accordion and autoresize (#601) Add card test (#622) Add sidebar test (#631) Make card fullscreen icon a tooltip (#632) Pull in changes from rstudio/bslib#697 and rstudio/bslib#699 Changelog tweak. Followup to #629 Add experimental tooltip methods and example apps (#629) Use `blib::bs_theme(5,"shiny")` for py-shiny theme (#624) Rename shiny/examples to shiny/api-examples (and X/examples to X/api-examples) (#627) Make --app-path work with app file argument (#598) Don't eval example code block Fix example code blocks (#626) Annotation export example (#584) Add todo list example (#603)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the regression described in #698 to restore full screen behavior of value boxes.
Fixes #698
Regression was discovered via https://rstudio.github.io/shinycoreci/results/2023/07/19/#305-bslib-value-box