Enable contributors to run tests without having to set PYTHONPATH=. #151
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterthesling
force-pushed
the
pthesling/run-tests-without-setting-pythonpath
branch
4 times, most recently
from
13d3d0a to
0a3090c
Compare
peterthesling
force-pushed
the
pthesling/run-tests-without-setting-pythonpath
branch
from
0a3090c to
cbc3bad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently contributors have to set
PYTHONPATH=.in order to run tests successfully.According to pytest-dev/pytest#2287 (comment) we should instruct contributors to run
pip install -e .. That is already something we do suggest here, however only for the pipelines folder. Movingpipelines/setup.pyto the repo root fixes this.