Skip to content

Replace itm-decode with itm reimplementation #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Dec 7, 2021

Conversation

tmplt
Copy link
Member

@tmplt tmplt commented Dec 7, 2021

itm-decode replaced the old itm crate. In the last few weeks, the itm-decode crate has been refactored to mimic some of the API that the old itm crate had in order to replace it, deprecating itm-decode such that only a single canonical ITM packet decoder is offered.

More on the topic at rust-embedded/wg#589

@tmplt tmplt force-pushed the refactor/replace-itm-decode branch from af634a0 to 3c222c1 Compare December 7, 2021 11:14
@tmplt
Copy link
Member Author

tmplt commented Dec 7, 2021

We should wait for rust-embedded/cortex-m#366 until we merge so that we can fix the cortex-m pins.

tmplt added 4 commits December 7, 2021 13:23
Messed up with the lock file, so now rc.2 no longer builds. I'm guessing
it's caused by relative pins in the crate, and not commit-accurate pins.
The lock file can be removed when v0.6 releases.
@tmplt tmplt force-pushed the refactor/replace-itm-decode branch from 32d8660 to b384be0 Compare December 7, 2021 13:48
@tmplt
Copy link
Member Author

tmplt commented Dec 7, 2021

I expected the output test to break because of the itm structure changes, but that test was disabled in decc282, so it will be a problem for another day.

We'll merge now with a passing CI and fix cortex-m pins before v0.3.0 is tagged.

@tmplt tmplt merged commit b384be0 into master Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant