spawning.debian is missing --daemonize

[AdamG]

The example spawning.debian is missing --daemonize, which, among other things, means that CHUID isn't used.

see: 712bed9:

Was lost when args were moved into DAEMON_ARGS:
712bed9#L0L86
712bed9#L0R66

Should be added to the default DAEMON_ARGS here:

https://github.com/rtyler/Spawning/blob/master/rc-scripts/init.d/spawning.debian#L66

[AdamG]

After finding that "stop" doesn't work when using --daemonize (the pid isn't correct), I'm thinking that it is likely intentionally missing. start-stop-daemon is called with --background, which is meant to be used when the program doesn't exit on it's own, which spawning wouldn't without --daemonize. However, this isn't the correct behavior; it means that some settings (like CHUID) in the init script configuration section are ignored, and the daemon ends up running as root.

I think --daemonize and --pidfile should be added to DAEMON_ARGS, and start-stop-daemon should be called without --background or --make-pidfile. I'm not very familiar with debian's init.d stuff, so I could be wrong. I'll update if that approach works.

[AdamG]

Well, this is just a mess. If you use CHUID, the default pidfile location (with "# Don't edit this" above it) isn't writable. I was able to get it working for my purposes by changing the pidfile path to an app-writable directory.

start-stop-daemon also has it's own --chuid. I don't know whether it should be done there and --daemonize left out at the expense of any daemon-specific behavior in spawning, or if the pidfile location should be somewhere world-writable by default. So, I'm inclined to punt this to someone who knows how this should work.

At a minimum, --chuid should be passed to start-stop-daemon in the current script. But it may well be that --daemonize isn't actually needed, since start-stop-daemon seems to handle non-daemonized processes just fine.