Repository navigation
Relax rack dependency for Rails 4 - #68
Merged
Merged
Conversation
Contributor
|
I think your suggestion is a good one. Probably we should also leave some note in the gemspec about that dependency. |
buehmann
force-pushed
the
relax-rack-dependency
branch
from
June 5, 2019 09:47
0e96c23 to
bd166f6
Compare
Closed
koic
approved these changes
Jun 8, 2019
|
Would it be possible to have a rubocop-rails build 2.0.1 including this change? All previous rubocop-rails versions have been yanked from rubygems. Now all our rails 4 project builds are broken due to rubocop-rails not being available anymore. |
Member
|
RuboCop Rails 2.0.1 has been released. This release includes this patch. |
5 of 8 tasks
koic
added a commit
to koic/rubocop
that referenced
this pull request
Jun 11, 2019
This PR drops development dependency on Rack gem. This dependency was introduced at rubocop#5597 for `Rails/HttpStatus` cop. Rails cops has been removed in rubocop#7095 from RuboCop core and the dependency on Rack gem is maintained by RuboCop Rails repo. rubocop/rubocop-rails#68
bbatsov
pushed a commit
to rubocop/rubocop
that referenced
this pull request
Jun 11, 2019
This PR drops development dependency on Rack gem. This dependency was introduced at #5597 for `Rails/HttpStatus` cop. Rails cops has been removed in #7095 from RuboCop core and the dependency on Rack gem is maintained by RuboCop Rails repo. rubocop/rubocop-rails#68
koic
added a commit
to koic/rubocop-rails
that referenced
this pull request
Jun 15, 2019
This PR drops Rails 3 support. RuboCop core was supported Rails 4+. https://github.com/rubocop-hq/rubocop/tree/v0.71.0#compatibility > The Rails cops support the following versions: > > - Rails 4.0+ It conforms to the expected behavior of RuboCop core originally. And Rails is maintained at 4.2.Z or higher. > 4 Severe Security Issues > For severe security issues all releases in the current major series, and > also the last major release series will receive patches and new > versions. The classification of the security issue is judged by the core > team. > > Currently included series: 5.2.Z, 5.1.Z, 5.0.Z, 4.2.Z. https://guides.rubyonrails.org/maintenance_policy.html The following is the RuboCop Rails and Rails 4 use case. rubocop#68
6 of 8 tasks
koic
added a commit
to koic/rubocop-rails
that referenced
this pull request
Jun 15, 2019
This PR drops Rails 3 support. RuboCop core was supported Rails 4+. https://github.com/rubocop-hq/rubocop/tree/v0.71.0#compatibility > The Rails cops support the following versions: > > - Rails 4.0+ It conforms to the expected behavior of RuboCop core originally. And Rails is maintained at 4.2.Z or higher. > 4 Severe Security Issues > For severe security issues all releases in the current major series, and > also the last major release series will receive patches and new > versions. The classification of the security issue is judged by the core > team. > > Currently included series: 5.2.Z, 5.1.Z, 5.0.Z, 4.2.Z. https://guides.rubyonrails.org/maintenance_policy.html The following is the RuboCop Rails and Rails 4 use case. rubocop#68
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is related to #37.
rackwas recently made a runtime dependency: #36:Now this conflicts with an older Rails 4 app of ours which requires an older rack version:
The only rack interface that is used seems to be
::Rack::Utils::SYMBOL_TO_STATUS_CODEwhich first appeared in rack 1.1: rack/rack@5c4bd17Is there a particular reason why you enforce rack >= 2.0 or could we relax that dependency?