Skip to content

update existing spec to test correct behavior of missing nested array #1848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

hyunskang
Copy link

@hyunskang hyunskang commented Dec 14, 2018

Modifies existing test for nested arrays to verify that the key is mapped to an Array object. Test fails because declared transforms the missing Array params into a Hash.

Related Issue: #1847

@grape-bot
Copy link

grape-bot commented Dec 14, 2018

1 Warning
⚠️ Unless you’re refactoring existing code, please update CHANGELOG.md.
1 Message
📖 We really appreciate pull requests that demonstrate issues, even without a fix. That said, the next step is to try and fix the failing tests!

Here's an example of a CHANGELOG.md entry:

* [#1848](https://github.com/ruby-grape/grape/pull/1848): Update existing spec to test correct behavior of missing nested array - [@hyunskang](https://github.com/hyunskang).

Generated by 🚫 danger

@dnesteryuk
Copy link
Member

@hyunskang thank you for this PR 👏 A similar test was added in #2043

@dnesteryuk dnesteryuk closed this May 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants