Simplify endpoint block execution and deprecate return
call in it
#2577
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecate Endpoint Return Value
Summary
This PR simplifies endpoint's block execution. It was relying on an
unbound
method but it always been re-binded to endpoint instance. Instead, I just callinstance_exec
from the endpoint instance. First, we deprecate and next version we will remove therescue LocalJumpError
.Motivation
return
in an endpoint. Seems to be an old thing.generate_api_method
was generating a couple of strings that were retained in memory. I've seen it in grape-on-rack.Changes
Grape::Endpoint#call
as deprecated in the documentation and code comments.lamba
instead ofProc
to be able to capture theLocalJumpError
and return its exit_value for not breaking anything.Impact
Grape::Endpoint#call
should update their code to avoid this pattern.Checklist