Remove unused cgi require for Ruby 3.5 compatibility
#713
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Ruby 3.5 this emits a warning since most of the `cgi` gem is being removed. i18n doesn't use this module anymore since the require was added 11 years ago, so it can just be removed to avoid the warning during require. https://bugs.ruby-lang.org/issues/21258
radar
approved these changes
Jun 23, 2025
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Ruby 3.5 this emits a warning since most of the
cgigem is being removed.i18n doesn't use this module anymore since the require was added 11 years ago, so it can just be removed to avoid the warning during require. Usage was removed in 6db6403
https://bugs.ruby-lang.org/issues/21258