Skip to content

[DOC] Document thread-safety of Digest algorithms #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

adam12
Copy link

@adam12 adam12 commented Mar 4, 2024

Using constants under the Digest:: namespace are loaded through const_missing, but this has been observed to not be thread-safe and can cause errors regarding Digest::Base. We should more prominently encourage the use of Digest() when loading dynamically or using an explicit require up front when the algorithm is known.

@adam12 adam12 requested a review from knu as a code owner March 4, 2024 21:45
@rickhull
Copy link

rickhull commented Mar 8, 2024

I was involved in discussion around this on the Ruby discord. This looks like a clear improvement to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants