Conversation
ksss
left a comment
ksss
left a comment
There was a problem hiding this comment.
The test code differs significantly from the ruby/rbs version, making it difficult to pinpoint the differences.
Can it be made as close to the original as possible?
If there are issues with the original, please let me know.
sferik
force-pushed
the
add-rbs-signatures
branch
2 times, most recently
from
1c7e9f0 to
0533460
Compare
|
Okay, I've copied the tests from |
ksss
left a comment
ksss
left a comment
There was a problem hiding this comment.
NetHTTPTestSigHelper and NetHTTPRBSTestCase should be removed.
This approach does not allow us to confirm if the manifest.yaml specification is sufficient.
Additionally, library should be used.
This is a DSL that explicitly states that only the specified library has been loaded.
library "net-http"
testing "singleton(::Net::HTTP)"
|
@ksss How does that look? |
sferik
force-pushed
the
add-rbs-signatures
branch
from
c8545ed to
e3b1e4b
Compare
ksss
left a comment
ksss
left a comment
There was a problem hiding this comment.
I think it's almost good.
The test_sig should be excluded from spec.files in net-http.gemspec at the end..
sferik
force-pushed
the
add-rbs-signatures
branch
from
e3b1e4b to
26c3060
Compare
|
@ksss Done. |
sferik
force-pushed
the
add-rbs-signatures
branch
from
26c3060 to
23a1043
Compare
Replace custom NetHTTPTestSigHelper/NetHTTPRBSTestCase with the standard RBS::UnitTest library DSL, which validates that manifest.yaml declares all required dependencies.
sferik
force-pushed
the
add-rbs-signatures
branch
from
23a1043 to
5191d32
Compare
|
@ksss Thank you for taking the time to thoroughly review it. |
2 participants
See #278 for context.