Suppress OpenSSL-3 warnings #576
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rhenium We hope to merge this before Ruby 3.2.0-preview4 or final release. Can you look this? |
|
Merged, thank you. I agree suppressing the warnings is the best way forward for now. Those warnings (both casting const pointers and deprecation) are due to the use of the legacy low-level structs. This is a problem for us not only because of the warnings, but because using a legacy function requires EVP_PKEY to convert itself to a "legacy PKEY" (as opposed to "provided PKEY"), which means we can't use other EVP_PKEY functions that are based on OpenSSL providers, such as EVP_PKEY_todata(). I was hoping we could gradually fix them by replacing them with the appropriate EVP_PKEY API, but this doesn't seem to be possible in the short term. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.