Reject true && not true
#3585
Open
Reject true && not true
#3585
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A command-call-like `not true` must be rejected after `&&` and `||`. https://bugs.ruby-lang.org/issues/21337
mame
commented
Jun 13, 2025
| true && not (true) | ||
| ^ expected a `(` after `not` | ||
| ^ unexpected '(', expecting end-of-input | ||
|
|
There was a problem hiding this comment.
I wanted to add a test to confirm that
true && not
true
be rejected, but I am not sure how to write the test.
|
|
||
| true && not (true) | ||
| ^ expected a `(` after `not` | ||
| ^ unexpected '(', expecting end-of-input |
There was a problem hiding this comment.
This error message is a bit weird, but I am not sure how to fix it.
|
This looks correct!! I can fix the error messages next Monday |
|
@kddnewton Just a gentle follow-up on the PR I sent. I believe this fix is somewhat time-sensitive. Since the bug can lead to invalid Ruby code being written, it would be great to get it resolved before it spreads further. Ideally, it could also be backported to Ruby 3.4.5. Please let me know if there's anything I can do to help move it forward. Thanks so much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A command-call-like
not truemust be rejected after&&and||.https://bugs.ruby-lang.org/issues/21337