You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I understand the reasoning but I'm not sure if it's a good solution.
sdoc (and some other projects using rdoc) have various levels of patches on rdoc. If we need to avoid breaking them, it'll dramatically limit our ability to improve rdoc's codebase. For example, I think we should do #1309 even if it breaks sdoc as Store should be considered private.
And even if we think changes like #1309 is breaking and will release it with a major version bump, it'd still break the job nonetheless until 1) we cut the release, and 2) sdoc adopts the version and update its codebase for it. And before both of those happens we'd just have a broken CI.
Sure, we may say it'd be an optional job that's allowed to be broken. But from my experience those jobs will always be ignored and removed after a while as the value of maintaining it is low.
A more common, and maybe effective approach, would be for sdoc to run CI against the latest rdoc and provide feedback close to when the changes are merged.
Things could still break, but ideally we'll catch and improve most of them before releases.
It'll prevent introducing breaking changes for SDoc.
See also: #1304 (comment)
The text was updated successfully, but these errors were encountered: