Place a space between certain character class letters only#1057
Merged
nobu merged 1 commit intoruby:masterfrom Nov 27, 2023
Merged
Place a space between certain character class letters only#1057nobu merged 1 commit intoruby:masterfrom
nobu merged 1 commit intoruby:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basis
Japanese text is not usually space-separated per words, and can be folded at almost any places except for around some punctuations.
That means, line breaks in Japanese sentences should be removed and not replaced with spaces like in English sentences.
Problem
However, RDoc blindly replaces line breaks with spaces, resulting in very unnatural gaps in Japanese text, highlighted in the screenshot below.
This makes it impossible to select words by double-clicking, for example.
Fix
With this patch, only line breaks between
SPACE_SEPARATED_LETTER_CLASScharacters will be replaced with spaces.SPACE_SEPARATED_LETTER_CLASSincludesDecimal_Number,Cased_Letter, andConnector_Punctuationfor now, as an analog to\w.