Merged
Conversation
This is similar what IRB and Reline have: a CI suite that runs RDoc changes against Ruby's master branch. It's been very useful to catch issues that would otherwise break CRuby's CI suites.
martinemde
reviewed
Jun 22, 2024
martinemde
left a comment
martinemde
left a comment
There was a problem hiding this comment.
Makes sense to me. I read the workflow but I haven't seen the others, however, if it runs and passes then I say merge it.
simi
reviewed
Jun 22, 2024
| branches: | ||
| - master | ||
|
|
||
| concurrency: |
hsbt
approved these changes
Jun 24, 2024
Member
hsbt
left a comment
hsbt
left a comment
There was a problem hiding this comment.
Looks good.
We should consider to move this job as re-using workflow on https://github.com/ruby/actions.
The repositories under the Ruby org only call it.
Member
Author
|
@hsbt Thx, I added it to my todo list 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is similar what IRB and Reline have: a CI suite that runs RDoc changes against Ruby's master branch. It's been very useful to catch issues that would otherwise break CRuby's CI suites.