Drop unnecessary file_name parameter from Parser.for method.#1135
Merged
Drop unnecessary file_name parameter from Parser.for method.#1135
file_name parameter from Parser.for method.#1135Conversation
It should be always the same as the top_level's absolute_name, so there's no point of taking it as a separate parameter.
colby-swandale
approved these changes
Jul 31, 2024
matzbot
pushed a commit
to ruby/ruby
that referenced
this pull request
Jul 31, 2024
method. (ruby/rdoc#1135) * Unify top_level creation in tests * Remove unnecessary file_name param from Parser.for It should be always the same as the top_level's absolute_name, so there's no point of taking it as a separate parameter. ruby/rdoc@97c497dfbb
st0012
added a commit
that referenced
this pull request
Jan 27, 2025
) Similar to #1135, the `file_name` argument's value should be the name as `top_level.absolute_name`. So passing it separately is not necessary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first commit refactors
RDocParser's tests without changing lib code.The second commit removes the unnecessary
file_nameargument fromParser.foras it should always be the same astop_level.absolute_name. We can be sure about this because it only has one caller, and it receives the samefilenamevalue as the one that's used to create thetop_level, which we know will be stored as the itsabsolute_nameattribute.