Only let browser search through source code until it's expanded#1181
Merged
st0012 merged 1 commit intoruby:masterfrom Sep 30, 2024
Merged
Only let browser search through source code until it's expanded#1181st0012 merged 1 commit intoruby:masterfrom
st0012 merged 1 commit intoruby:masterfrom
Conversation
Something that's been bothering me is that while the source code is not visible by default, the browser still jump to it when searching. Adding the `visible` property prevents this. Test it out yourself: * `bundle exec rdoc` * open `_site/index.html` * Search for `NameError` Before, you will get a match from `load_yaml` source code, after you only get the match when that methods source code is expanded.
colby-swandale
approved these changes
Sep 28, 2024
st0012
approved these changes
Sep 30, 2024
Member
st0012
left a comment
st0012
left a comment
There was a problem hiding this comment.
It's a great improvement, thank you 👍
matzbot
pushed a commit
to ruby/ruby
that referenced
this pull request
Sep 30, 2024
expanded (ruby/rdoc#1181) Something that's been bothering me is that while the source code is not visible by default, the browser still jump to it when searching. Adding the `visible` property prevents this. Test it out yourself: * `bundle exec rdoc` * open `_site/index.html` * Search for `NameError` Before, you will get a match from `load_yaml` source code, after you only get the match when that methods source code is expanded. ruby/rdoc@003126cc23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Something that's been bothering me is that while the source code is not visible by default, the browser still jump to it when searching. Adding the
visibleproperty prevents this.Test it out yourself:
bundle exec rdoc_site/RDoc.htmlNameErrorBefore, you will get a match from
load_yamlsource code, after you only get the match when that methods source code is expanded: