Improve how gemspec's files are defined#1212
Merged
Conversation
st0012
force-pushed
the
improve-gemspec-files
branch
from
b83411c to
fdc321b
Compare
Member
Author
|
@olleolleolle Thanks, updated 👍 |
nobu
reviewed
Nov 23, 2024
st0012
force-pushed
the
improve-gemspec-files
branch
from
fdc321b to
487e121
Compare
colby-swandale
approved these changes
Nov 25, 2024
Member
|
@hsbt Does this Pull Request impact any processes used for ruby-src? |
Member
Author
|
@colby-swandale If you're talking about |
Currently, the gemspec's files are defined by hand, which is error-prone. For example: #1211 This commit uses `Dir.glob` where possible to reduce the risk of that happening again. - Additional files added with this approach: ``` # This should have been added by only captured by this commit lib/rdoc/parser/prism_ruby.rb # These are folders and can be included/ignored either way lib/rdoc/generator/template/darkfish lib/rdoc/generator/template/darkfish/css lib/rdoc/generator/template/darkfish/fonts lib/rdoc/generator/template/darkfish/images lib/rdoc/generator/template/darkfish/js lib/rdoc/generator/template/json_index lib/rdoc/generator/template/json_index/js ``` - Files that are ignored after this change: ``` # They make no difference on documentation generation # Probably can be removed lib/rdoc/generator/template/darkfish/.document lib/rdoc/generator/template/json_index/.document ```
st0012
force-pushed
the
improve-gemspec-files
branch
from
487e121 to
b80dc95
Compare
Member
|
I don't like But we can use trusted publisher now, it provides clean build and publish environments for us. I'm okay to this change. |
Member
|
|
matzbot
pushed a commit
to ruby/ruby
that referenced
this pull request
Nov 28, 2024
(ruby/rdoc#1212) Currently, the gemspec's files are defined by hand, which is error-prone. For example: ruby/rdoc#1211 This commit uses `Dir.glob` where possible to reduce the risk of that happening again. - Additional files added with this approach: ``` # This should have been added by only captured by this commit lib/rdoc/parser/prism_ruby.rb # These are folders and can be included/ignored either way lib/rdoc/generator/template/darkfish lib/rdoc/generator/template/darkfish/css lib/rdoc/generator/template/darkfish/fonts lib/rdoc/generator/template/darkfish/images lib/rdoc/generator/template/darkfish/js lib/rdoc/generator/template/json_index lib/rdoc/generator/template/json_index/js ``` - Files that are ignored after this change: ``` # They make no difference on documentation generation # Probably can be removed lib/rdoc/generator/template/darkfish/.document lib/rdoc/generator/template/json_index/.document ``` ruby/rdoc@ac2a151f10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the gemspec's files are defined by hand, which is error-prone.
For example: #1211
This commit uses
Dir.globwhere possible to reduce the risk of that happening again.Additional files added with this approach:
Files that are ignored after this change: