Refactor darkfish's classes sidebar implementation #1296
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tompng
reviewed
Feb 19, 2025
Deploying rdoc with
|
| Latest commit: |
609cf83
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://bef32db6.rdoc-6cd.pages.dev |
| Branch Preview URL: | https://refactor-darkfish-implementa.rdoc-6cd.pages.dev |
The current usage always respects the `klass.display?` value, so we don't need to pass it to the proc.
Given the generation involves recursion and multiple conditions, it's easier to follow if we move them out of ERB and into the Ruby code.
st0012
force-pushed
the
refactor-darkfish-implementation
branch
from
8b259c2 to
88ae47f
Compare
|
BTW, I think we can later do the same refactor for |
tompng
reviewed
Feb 19, 2025
st0012
force-pushed
the
refactor-darkfish-implementation
branch
from
88ae47f to
609cf83
Compare
tompng
approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current logic written in ERB template is super hard to read and understand. I think given its complexity is makes sense to implement those logic in pure Ruby methods instead of ERB code in a view.