Image alt tag header formatting #1320
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ioquatix
force-pushed
the
image-alt-tag-header-formatting
branch
from
d53617f to
9ef4934
Compare
st0012
reviewed
Mar 20, 2025
tompng
reviewed
Mar 20, 2025
| { | ||
| # Extract alt text and URL | ||
| alt_text = a[/\{(.*?)\}/, 1] || "" | ||
| url = a[/\[(.*?)\]/, 1] || "" |
There was a problem hiding this comment.
a is a String that always match to these regexp because ExplicitLink:a is created by "{#{l}}[#{s}]".
Perhaps it could be more simple if ExplicitLink returns structured data
ExplicitLink = Label:l "(" @Sp Source:s Spnl Title @Sp ")"
- { "{#{l}}[#{s}]" } # returns string, need to parse this string again...
+ { { label: l, source: s } } # can return hash(need to change Link = ExplicitLink | ReferenceLink | AutoLink to return a string if ExplicitLink returns hash)
There was a problem hiding this comment.
Could we do this in a follow-up PR? I think it's out of scope for this PR.
tompng
reviewed
Mar 20, 2025
Co-authored-by: Stan Lo <[email protected]>
|
Thanks everyone! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to parse the alt text from Markdown images, formatting a header text correctly (using the alt text).
Without this PR, if a Markdown file has an image instead of a title, that image will be used in the table of contents, which is unreadable and undesirable.
Used in rack/rack#2313.