Aliki: Make hamburger toggle non-selectable#1480
Conversation
Earlopain
temporarily deployed
to
fork-preview-protection
GitHub Actions
Inactive
|
🚀 Preview deployment available at: https://3d1eecb4.rdoc-6cd.pages.dev (commit: 96c442b) |
|
I'm not sure if I misunderstood the desired behavior, but the preview site's hamburger icon is still selectable?
|
|
Ugh, it needs to be prefixed for some browsers. I will fix this tomorrow |
Earlopain
force-pushed
the
aliki-hamburger-non-selectable
branch
from
02b2823 to
22cffa5
Compare
Earlopain
temporarily deployed
to
fork-preview-protection
GitHub Actions
Inactive
|
I added fallback for safari, which I guess you were using. I don't know what your browser targets are, here's the browser support: https://caniuse.com/user-select-none. Some older versions of firefox also have their own prefix but usage is very low, so probably not worth it? Same for internet explorer. Seems like stylelint doesn't like it though? |
It's implemented via an utf8 character but should not be selected by double-clicking. `property-no-vendor-prefix` is disabled because no autoprefixer is used
Earlopain
force-pushed
the
aliki-hamburger-non-selectable
branch
from
22cffa5 to
96c442b
Compare
Earlopain
temporarily deployed
to
fork-preview-protection
GitHub Actions
Inactive
Yeah, it is ( think). I guess stylelint expects you to do some postprocessing on the files so this happens automatically. I disabled the rule |
3 participants
It's implemented via an utf8 character but should not be selected by double-clicking
Ref #1479