Fix complex condition in for/while/until#480
Merged
hsbt merged 2 commits intoruby:masterfrom Aug 8, 2017
Merged
Conversation
The parse_statements method calls skip_optional_do_after_expression method in case of for/while/until tokens. The skip_optional_do_after_expression method uses get_end_token method for checking end of loop condition expressions, but it's not correct, because the end is detected by only "do" token, newline and semi-colon token. This commit fixes it.
cfcd5f2 to
1917d08
Compare
1917d08 to
c0efaf5
Compare
Member
|
Confirmed. Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
parse_statements methodcallsskip_optional_do_after_expressionin case offor/while/untiltokens. Theskip_optional_do_after_expressionusesget_end_tokenfor checking end of loop condition expressions, but it's not correct, because the end is detected by onlydotoken, newline and semi-colon token.For example,
This code is highlighted below:
I think this is broken. This Pull Request fixes it: