Merged
Conversation
Regexp literal is detected by what @lex_state is :EXPR_BEG or :EXPR_MID. But when regexp literal is after method name in oneliner, @lex_state is :EXPR_END and the regexp literal becomes broken tokens. This commit fixes it.
hsbt
requested changes
Aug 23, 2017
| assert_equal markup_code, expected | ||
| end | ||
|
|
||
| def test_parse_statements_postfix_if_after_heredocbeg |
Member
There was a problem hiding this comment.
Is it needless test case? It seems regression with merging master branch.
aycabta
force-pushed
the
fix-regexp-literal-in-oneliner
branch
from
5691aba to
9762de4
Compare
Member
Author
|
I fixed it now, I mistook merging yesteday. More haste, less speed. |
Member
|
I heared this fix resolve |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regexp literal is detected by what
@lex_stateis:EXPR_BEGor:EXPR_MID. But when regexp literal is after method name in oneliner,@lex_stateis:EXPR_ENDand the regexp literal becomes broken tokens.This Pull Request fixes it.