Skip to content

Log full lines unless output is a tty #671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 4, 2018
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 16 additions & 16 deletions lib/rdoc/stats/normal.rb
Original file line number Diff line number Diff line change
Expand Up @@ -26,28 +26,28 @@ def print_file files_so_far, filename
files_so_far,
@num_files)

# Print a progress bar, but make sure it fits on a single line. Filename
# will be truncated if necessary.
size = IO.respond_to?(:console_size) ? IO.console_size : IO.console.winsize
terminal_width = size[1].to_i.nonzero? || 80
max_filename_size = terminal_width - progress_bar.size

if filename.size > max_filename_size then
# Turn "some_long_filename.rb" to "...ong_filename.rb"
filename = filename[(filename.size - max_filename_size) .. -1]
filename[0..2] = "..."
end

line = "#{progress_bar}#{filename}"
if $stdout.tty?
# Print a progress bar, but make sure it fits on a single line. Filename
# will be truncated if necessary.
size = IO.respond_to?(:console_size) ? IO.console_size : IO.console.winsize
terminal_width = size[1].to_i.nonzero? || 80
max_filename_size = terminal_width - progress_bar.size

if filename.size > max_filename_size then
# Turn "some_long_filename.rb" to "...ong_filename.rb"
filename = filename[(filename.size - max_filename_size) .. -1]
filename[0..2] = "..."
end

# Clean the line with whitespaces so that leftover output from the
# previous line doesn't show up.
$stdout.print("\r\e[K") if @last_width && @last_width > 0
@last_width = line.size
$stdout.print("#{line}\r")
@last_width = progress_bar.size + filename.size
term = "\r"
else
$stdout.puts(line)
term = "\n"
end
$stdout.print(progress_bar, filename, term)
$stdout.flush
end

Expand Down