Use test-unit instead of minitest #673

nobu · 2018-12-02T02:50:20Z

Minitest 6 will err assert_equal with nil, as minitest/minitest#779, even if the first argument is not a literal.

hsbt · 2018-12-07T06:51:25Z

I have no strong opinion to switch test-unit from minitest. When we accept this patch, We need to change minitest_helpr.rb to test_helper.rb.

hsbt · 2019-08-08T10:53:49Z

@nobu Can you rebase this? It's time to merge this.

Minitest 6 will err `assert_equal` with `nil`. minitest/minitest#779

nobu · 2019-08-08T14:10:11Z

test_helper.rb will be a subject of tests.
I renamed it as just helper.rb.

nobu force-pushed the feature/test-unit branch from 81d0bb8 to d91ce2b Compare December 5, 2018 00:14

nobu force-pushed the feature/test-unit branch from d91ce2b to 5f45dc3 Compare December 10, 2018 00:50

nobu force-pushed the feature/test-unit branch from 5f45dc3 to 8c158bd Compare April 1, 2019 04:34

nobu added 2 commits August 8, 2019 22:40

Use test-unit instead of minitest

8e6d58a

Minitest 6 will err `assert_equal` with `nil`. minitest/minitest#779

Use locale directory for the tests

45ce45a

nobu force-pushed the feature/test-unit branch from 8c158bd to 45ce45a Compare August 8, 2019 13:42

Renamed minitest_helper.rb as helper.rb

c1ae23d

hsbt merged commit 6347dd0 into ruby:master Aug 9, 2019

Provide feedback