Support single quotes in mise format ruby version #9183
Merged
+40
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kou
reviewed
Dec 11, 2025
bundler/lib/bundler/ruby_dsl.rb
Outdated
| [^\s#"']+ # One or more chars that aren't spaces, #, or quotes | ||
| ) # End capturing group | ||
| "? # Optional closing quote | ||
| ["']? # Optional closing quote |
Member
There was a problem hiding this comment.
Can we reject "3.2.2' (quote mismatch)?
The previous regex didn't properly match quoted strings it would capture the opening quote as part of the version if quotes were mismatched. This change properly parses double-quoted, single-quoted, and unquoted version strings separately.
hituzi-no-sippo
commented
Dec 13, 2025
| end | ||
|
|
||
| it "raises an error" do | ||
| expect { subject }.to raise_error(Bundler::InvalidArgumentError, "= is not a valid requirement on the Ruby version") |
Contributor
Author
There was a problem hiding this comment.
I'm not sure if the error message = is not a valid requirement ... is appropriate.
If I add = to ([^\s#"']+) # Unquoted version to make it ([^\s#"'=]+), the error message would become [tools]\nruby = \"2.0.0' is not a valid requirement ..., which I feel is better than = is not a valid requirement.
However, I'm concerned this change to ([^\s#"'=]+) might introduce regressions.
Member
There was a problem hiding this comment.
Let's not make any changes involving = at this time, as we don't yet fully support the mise format.
FYI: #8998
hsbt
approved these changes
Dec 16, 2025
hsbt
added a commit
that referenced
this pull request
Dec 16, 2025
…ise-format Support single quotes in mise format ruby version (cherry picked from commit 6b618d9)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
mise.tomlsupports specifying Ruby versions using both double quotes (ruby = "3.2.2") and single quotes (ruby = '3.2.2'). However, Bundler'sruby file:directive only recognized double-quoted versions, causing single-quoted versions to fail parsing.What is your fix for the problem, implemented in this PR?
Updated the regular expression to accept both single quotes (
') and double quotes (") when parsing Ruby version files in mise format.Make sure the following tasks are checked