Add URINormalizer trailing slash specs #9214
Merged
+26
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
The trailing-slash normalization behavior in Bundler affects lockfile expectations (gem sources keep a trailing slash, git sources do not), but there were no focused specs to lock that behavior. This made future normalization changes risky and prone to unintended lockfile diffs.
What is your fix for the problem, implemented in this PR?
Add a focused spec for
Bundler::URINormalizer.normalize_suffixcovering bothtrailing_slash: trueandfalsewith inputs that do and do not already include a trailing slash. This locks the current behavior and makes future refactors safer.Tests:
cd bundler && bin/rspec spec/bundler/uri_normalizer_spec.rb(fails locally: missingrubygems-generate_indexgem)Make sure the following tasks are checked