Allows set viewport for screenshot#406
Merged
route merged 2 commits intorubycdp:mainfrom Sep 26, 2023
erickgskovik:support-set-viewport
Merged
Allows set viewport for screenshot#406route merged 2 commits intorubycdp:mainfrom erickgskovik:support-set-viewport
route merged 2 commits intorubycdp:mainfrom
erickgskovik:support-set-viewport
Conversation
Also removes a not used test page.
Member
|
Looking good, thx! |
Contributor
Author
|
Thanks! I have last one for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During screenshots, I found the window bounds doesn't change how the screenshot looks like.
And from my simple test for screenshoting a long page around 40000px height,
Emulation.setDeviceMetricsOverride(8s) withdeviceScaleFactoris faster thanscaleinPage.captureScreenshot(12s).Fixes #389.