feat: Supports capture area screenshot#410
Merged
route merged 1 commit intorubycdp:mainfrom Nov 9, 2023
erickgskovik:support-area-screenshot
Merged
feat: Supports capture area screenshot#410route merged 1 commit intorubycdp:mainfrom erickgskovik:support-area-screenshot
route merged 1 commit intorubycdp:mainfrom
erickgskovik:support-area-screenshot
Conversation
Contributor
|
@route friendly ping 😄 |
Member
|
I'm back and going one by one from top to bottom ;) |
Member
|
Thanks, nice job! |
This was referenced Nov 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #389
I made
selectorandareaoptional arguments. In the implementation, I think that the pull requests shows the true intention of the screenshot region.If
full: true, It tries to capture full screenshot with full size browser window and then viewport if the full size is not accurate.If
full: false,:selectoris preferred if defined. Then:area. Otherwise, the default will be the viewport.Applying default scale (1.0) will not affect the result anyway.