Display documents count on Topic index (no counter cache) #223
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bullet suggests to use a counter cache, but I'm trying it without one as discussed in PR #217.
I discussed this with Danny and Dmitry and also looked at Rack Mini Profiler. The Bullet alert seems to be a false positive, it may not be worth using a counter cache for the documents count.
dmitrytrager
approved these changes
Jun 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Issue Does This PR Cover, If Any?
Resolves #213
What Changed? And Why Did It Change?
This is an alternative to #217, as discussed with @dcollie2 and @dmitrytrager.
How Has This Been Tested?
I added between 1 and 10 files to all the Topics on the first page and added topic.documents.size.
Bullet was giving these warnings:
I added the rack-mini-profiler gem and checked performance, which seemed to be OK, so I silenced the alert.
Please Provide Screenshots
Additional Comments
N/A