web: Test with Node.js 25 instead of 22 (in addition to 24)#21953
Merged
kjarosh merged 1 commit intoruffle-rs:masterfrom Mar 14, 2026
Merged
web: Test with Node.js 25 instead of 22 (in addition to 24)#21953kjarosh merged 1 commit intoruffle-rs:masterfrom
kjarosh merged 1 commit intoruffle-rs:masterfrom
Conversation
torokati44
added
A-web
Contributor
|
I don't mind this and it's how we've done updates in the past, but worth noting the odd number releases always have significantly shorter life-cycles than the even number releases. Node 22 will remain the maintenance release for over a year after Node 25 goes entirely out of maintenance: https://nodejs.org/en/about/previous-releases#release-schedule |
Contributor
|
Still, the point of the tests is to catch breaking issues as early as possible, and the builds are still being done with even number releases, so it's probably fine. There's just the opposite argument to be had about testing for breakages with the maintenance release too. If CI resources were infinite, we'd ideally test both, but 🤷 |
torokati44
force-pushed
the
node-js-24-25
branch
from
b119e3d to
9d4084d
Compare
torokati44
added
the
waiting-on-review
torokati44
force-pushed
the
node-js-24-25
branch
from
9d4084d to
e22a866
Compare
torokati44
force-pushed
the
node-js-24-25
branch
2 times, most recently
from
470848a to
b8eab21
Compare
torokati44
force-pushed
the
node-js-24-25
branch
from
b8eab21 to
6060a6b
Compare
Member
Author
|
I can has merge plz |
torokati44
force-pushed
the
node-js-24-25
branch
from
6060a6b to
c75dfde
Compare
torokati44
force-pushed
the
node-js-24-25
branch
from
c75dfde to
f3d6c0e
Compare
kjarosh
approved these changes
Mar 14, 2026
kjarosh
removed
the
waiting-on-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Referencing #18780, #20362, and #21950.
This will also necessitate updating the set of required checks for PRs, as usual.