chore: Update lyon and update image tests based on the changes#22961
chore: Update lyon and update image tests based on the changes#22961danielhjacobs wants to merge 1 commit intoruffle-rs:masterfrom
Conversation
|
In case you did a "global" |
c586648 to
c54bf3b
Compare
8377bdd to
de7f59f
Compare
|
Are the new images from FP or from Ruffle? |
There was a problem hiding this comment.
c.f.: github.com/torokati44/ruffle/commit/33840417a40c6f249ffc4f716980cc71dea31bf4
How come euclid and libm needed to be bumped here, but not there?
And why leave lyon_geom version unchanged in Cargo.toml if it was bumped here?
Just curious, not saying either is better or worse.
There was a problem hiding this comment.
I did cargo install cargo-edit, then cargo upgrade -i -p lyon (https://stackoverflow.com/a/78514408/30680220), and it did this.
Before doing that, I tried just doing cargo update lyon, which didn't include these changes and committed that, but that told me "cannot update the lock file /home/runner/work/ruffle/ruffle/Cargo.lock because --locked was passed to prevent this" (https://github.com/ruffle-rs/ruffle/actions/runs/21757252217/job/62770890789)
|
From Ruffle, but here's a different question: were the old images from Flash Player either? |
|
I don't think so, that's why they need to be updated now (and possibly again in the future). |
|
The proper thing to do would be check each of them to see if they match Flash Player more accurately now than they did before, but:
|
|
Sure, it's understandable. It was Ruffle images all along exactly because capturing FP is non-trivial. |
|
kjarosh suggested on Discord we should take the output from Flash. It will take me some time to update this PR doing that. |
b0318e1 to
ecf09a6
Compare
ecf09a6 to
f86b567
Compare

No description provided.