refactor(macros): improve diagnostics, hygiene, and safety across pro…#23017
Open
DerrickRichard wants to merge 2 commits intoruffle-rs:masterfrom
Open
refactor(macros): improve diagnostics, hygiene, and safety across pro…#23017DerrickRichard wants to merge 2 commits intoruffle-rs:masterfrom
DerrickRichard wants to merge 2 commits intoruffle-rs:masterfrom
Conversation
…c-macro crate - Replaced panic/assert usage with proper syn::Error diagnostics - Added helper functions for cleaner structure and reduced duplication - Improved macro hygiene using mixed_site spans and internal name prefixes - Strengthened #[no_dynamic] override-prevention logic - Added identifier validation to atom!/istr! macros - Introduced feature flags for modular compilation
kjarosh
added
T-refactor
Member
|
Hi, thanks for your contribution! Just FYI: the code does not compile. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…c-macro crate