render: Improve gradient rendering#23059
Open
ChrisCPI wants to merge 4 commits intoruffle-rs:masterfrom
Open
Conversation
ed3d139 to
6d10b47
Compare
6d10b47 to
2cd8568
Compare
f9a12a1 to
42a93d3
Compare
kjarosh
reviewed
Feb 24, 2026
tests/tests/swfs/from_gnash/misc-ming.all/GradientFillTest/output.expected.png
Show resolved
Hide resolved
e867182 to
ff71022
Compare
Contributor
Author
|
Thinking about it, do I also need to update |
Member
|
Usually you'd do it in a separate PR and then rebase this one on top of that one. Otherwise you're breaking the test first and then fixing it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #21593 .
Rather than trying to grab the record with the lowest possible ratio and drawing it, wait until the current record has been drawn up to its ratio before moving on to the next record.
Also fixes some edge cases relating to when records have the same ratio.
The tests may need some work, because: