avm2: Don't store num_locals in Activation#23069
Open
moulins wants to merge 1 commit intoruffle-rs:masterfrom
Open
avm2: Don't store num_locals in Activation#23069moulins wants to merge 1 commit intoruffle-rs:masterfrom
num_locals in Activation#23069moulins wants to merge 1 commit intoruffle-rs:masterfrom
Conversation
moulins
added
A-avm2
To enable this: - in `Op::Debug`, store whether the stack slot is out-of-bounds or not; - in exception handling, retrieve the number of locals (used for resetting the stack) directly from the current method's body; this is slightly slower but catching errors is rare so this doesn't matter much.
moulins
force-pushed
the
avm2-activation-no-num-locals
branch
from
e03a52a to
3b23c62
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A (micro-)optimization that saves one
usizeperActivationon the stack.To enable this:
Op::Debug, store whether the stack slot is out-of-bounds or not;