avm2: Account for shared slot_id/disp_id numbering space in slot hole check#23145
Open
SuchAFuriousDeath wants to merge 2 commits intoruffle-rs:masterfrom
Open
avm2: Account for shared slot_id/disp_id numbering space in slot hole check#23145SuchAFuriousDeath wants to merge 2 commits intoruffle-rs:masterfrom
SuchAFuriousDeath wants to merge 2 commits intoruffle-rs:masterfrom
Conversation
SuchAFuriousDeath
force-pushed
the
fix-slot-auto-assign-direct-super
branch
from
b22ac67 to
7b089eb
Compare
Member
|
Can you elaborate on the fix? |
Collaborator
Author
|
Yeah sure, just give me a while. Just for context - I had Claude Code research and bisect the regression and it got a bit too enthusiastic and created the PR before I had a chance to review this (It misunderstood a prompt). But I can confirm that #22136 broke that game based on a bisect. |
SuchAFuriousDeath
force-pushed
the
fix-slot-auto-assign-direct-super
branch
from
7b089eb to
c3549ba
Compare
SuchAFuriousDeath
changed the title
SuchAFuriousDeath
force-pushed
the
fix-slot-auto-assign-direct-super
branch
from
c3549ba to
54f89b5
Compare
danielhjacobs
added
llm
SuchAFuriousDeath
force-pushed
the
fix-slot-auto-assign-direct-super
branch
from
54f89b5 to
3b49d2c
Compare
SuchAFuriousDeath
force-pushed
the
fix-slot-auto-assign-direct-super
branch
2 times, most recently
from
c23e66f to
792adaa
Compare
Collaborator
|
Adrian mentioned a case where this behavior causes a SWF that fails in FP to work in Ruffle over Discord. Can you add that as a test case? |
SuchAFuriousDeath
force-pushed
the
fix-slot-auto-assign-direct-super
branch
2 times, most recently
from
1925fed to
0358a72
Compare
Collaborator
Author
Added as a known_failure. |
SuchAFuriousDeath
force-pushed
the
fix-slot-auto-assign-direct-super
branch
from
0358a72 to
65d5b04
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #23143.