core: Non-root movies that AVM1 loads should always be considered AVM1#23183
Merged
Lord-McSweeney merged 4 commits intoruffle-rs:masterfrom Mar 8, 2026
Merged
core: Non-root movies that AVM1 loads should always be considered AVM1#23183Lord-McSweeney merged 4 commits intoruffle-rs:masterfrom
Lord-McSweeney merged 4 commits intoruffle-rs:masterfrom
Conversation
Lord-McSweeney
added
mixed-avm
Member
|
What if AVM2 loads AVM1, which loads AVM2? |
Collaborator
Author
|
Good point, I'll add test coverage for that too |
Lord-McSweeney
force-pushed
the
force-avm1
branch
from
aec0ba8 to
4b96eaa
Compare
Lord-McSweeney
added
the
waiting-on-review
kjarosh
reviewed
Mar 8, 2026
kjarosh
reviewed
Mar 8, 2026
| if !self.movie().is_action_script_3() { | ||
| match tag_code { | ||
| TagCode::DoAbc => tracing::warn!("DoABC tag in AVM1 movie"), | ||
| TagCode::DoAbc2 => tracing::warn!("DoABC2 tag in AVM1 movie"), |
Member
There was a problem hiding this comment.
Should we warn when !is_action_script_3 or !is_declared_action_script_3?
Collaborator
Author
There was a problem hiding this comment.
I would go with !is_action_script_3, as if AVM1 loads an AVM2 movie the tags will possibly unexpectedly not be executed
Member
There was a problem hiding this comment.
Sure, but then the warnings are a bit misleading? They suggest it's an AVM1 movie despite the fact it's declared as AVM2.
kjarosh
approved these changes
Mar 8, 2026
Member
|
Just to make sure: when AVM1 loads AVM2, the AVM2 cannot load anything as tags are not executed, right? |
Except for the purpose of Do(Init)Action tags, which always look at the version declared in the FileAttributes tag
This makes warning messages when DoABC tags are present in AVM1 movies more consistent
Rename some of the tests to make it more clear what they're doing
Lord-McSweeney
force-pushed
the
force-avm1
branch
from
4b96eaa to
2e6e5a6
Compare
Lord-McSweeney
removed
the
waiting-on-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #21007