Skip to content

chore: function docs, linting errors#3380

Merged
GenPage merged 7 commits intorunatlantis:mainfrom
pkaramol:functions_documentation
Jun 20, 2023
Merged

chore: function docs, linting errors#3380
GenPage merged 7 commits intorunatlantis:mainfrom
pkaramol:functions_documentation

Conversation

@pkaramol
Copy link
Copy Markdown
Contributor

@pkaramol pkaramol commented May 6, 2023

what

This PR:

  • adds a function documentation (more to be added as I go through the code); hopefully to make things easier for future contributors
  • fixes 2 linting errors by removing 2 unused (named) function arguments

why

tests

No functionality changes, no tests needed to run.

references

@pkaramol pkaramol requested a review from a team as a code owner May 6, 2023 12:14
@github-actions github-actions bot added the go Pull requests that update Go code label May 6, 2023
@github-actions github-actions bot added the build Relating to how we build Atlantis label May 6, 2023
@pkaramol pkaramol changed the title Function documentation and linting errors Function documentation, linting errors, ca-certificates version update for alpine May 6, 2023
@github-actions github-actions bot removed the build Relating to how we build Atlantis label May 7, 2023
@nitrocode nitrocode changed the title Function documentation, linting errors, ca-certificates version update for alpine chore: function docs, linting errors May 7, 2023
@GenPage GenPage added the waiting-on-review Waiting for a review from a maintainer label May 13, 2023
@GenPage GenPage merged commit 8514255 into runatlantis:main Jun 20, 2023
mtavaresmedeiros pushed a commit to mtavaresmedeiros/atlantis that referenced this pull request Jul 3, 2023
* Function documentation and linting errors

---------

Co-authored-by: Pantelis Karamolegkos <pantelis@workable.com>
Co-authored-by: nitrocode <7775707+nitrocode@users.noreply.github.com>
ijames-gc pushed a commit to gocardless/atlantis that referenced this pull request Feb 13, 2024
* Function documentation and linting errors

---------

Co-authored-by: Pantelis Karamolegkos <pantelis@workable.com>
Co-authored-by: nitrocode <7775707+nitrocode@users.noreply.github.com>
ijames-gc pushed a commit to gocardless/atlantis that referenced this pull request Feb 13, 2024
* Function documentation and linting errors

---------

Co-authored-by: Pantelis Karamolegkos <pantelis@workable.com>
Co-authored-by: nitrocode <7775707+nitrocode@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

go Pull requests that update Go code waiting-on-review Waiting for a review from a maintainer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants