chore(deps): website: Upgrade patch release of vuepress#3595
chore(deps): website: Upgrade patch release of vuepress#3595lukemassa wants to merge 2 commits intorunatlantis:mainfrom
Conversation
|
Looking at the error above, it looks like this probably requires a yarn update as well. When I ran it, at least locally, it produced a number of unexpected changes that I don't understand. If someone on the Atlantis side wants to push this through to fix the bug, that'd be great, otherwise like I said I can wait for whenever this is handled as part of a normal upgrade process. |
|
@lukemassa thanks for the contribution, can you check the errors please? |
8c8bdb6 to
b6fc905
Compare
Hi sorry @jamengual, I don't quite understand them. I assume it has something to do with my upgrading this package without upgrading the yarn.lock, however when I tried to run I'll just go ahead and close the PR, hopefully vuepress will be updated at some point in the future for this fix to go in. Apologies for the noise, thanks! |
|
FYI #3611 ended up pushing out this change, so now the website has the fix! :)
|

what
Small patch upgrade of vuepress, from 2.0.0-beta60 to 2.0.0-beta65
why
I noticed browsing https://www.runatlantis.io/docs/ that Luke Kysow's name appeared twice as a contributor.

I tracked this down to a bug in vuepress itself, which I was able to put in a fix for: vuepress/core#1364, which was subsequently released: https://github.com/vuepress/vuepress-next/blob/main/CHANGELOG.md. It turned out to treat automated commits different from manual ones, and the vuepress team agreed to merge them before showing on contributor field.
Now if I run the runatlantis.io site locally, you only see one:
I'm not sure of the cadence of updating this kind of dependency for Atlantis, I was just excited to get the fix in and wanted to bring it full circle to update it on the website here :) Feel free to close this if this bug doesn't seem important enough to have a dependency release "off cycle"; I'm happy to wait until it happens naturally.
tests
I ran the website locally and it fixed the issue (see above). I also clicked around a bit and everything seemed ok.
references
vuepress/core#1364