fix: make go-generate now creates working mocks out of the box#3802
Merged
GenPage merged 2 commits intorunatlantis:mainfrom Oct 6, 2023
Merged
fix: make go-generate now creates working mocks out of the box#3802GenPage merged 2 commits intorunatlantis:mainfrom
GenPage merged 2 commits intorunatlantis:mainfrom
Conversation
The code generated by pegomock is broken if any of the arguments to the mocked function are named "result", so they must be named something else.
The mocks now work without further modification after running go-generate.
ijames-gc
pushed a commit
to gocardless/atlantis
that referenced
this pull request
Feb 13, 2024
…lantis#3802) * Rename arguments in mocked functions from result to res The code generated by pegomock is broken if any of the arguments to the mocked function are named "result", so they must be named something else. * Regenerate all mocks with make go-generate The mocks now work without further modification after running go-generate.
ijames-gc
pushed a commit
to gocardless/atlantis
that referenced
this pull request
Feb 13, 2024
…lantis#3802) * Rename arguments in mocked functions from result to res The code generated by pegomock is broken if any of the arguments to the mocked function are named "result", so they must be named something else. * Regenerate all mocks with make go-generate The mocks now work without further modification after running go-generate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
what
Change some function parameter names from "result" to "res" so
pegomockcreates valid go code automatically.why
pegomock generates code that among other things contains
result := ..., which breaks if result exists as a function parameter. I don't know how this was handled before, I suspect manual editing after running make go-generate?tests
references