fix: Return correct status when using custom policy

[bakuljajan]

what

try to fix #4585. It seems the original code does not return error when the custom policy is enabled.

why

the error status was skipped causing plan/apply combined with custom policy check to always be successful.

tests

manual test only. will need guidance if additional tests are needed.

references

• Fixes [Custom Policy Check] Plan steps success despite statut error 1 #4585
• Fixes atlantis merges PR when apply fails and policy checks are enabled #4861

[jamengual]

@bakuljajan, do you think you could add a test for this?

Thanks.

[bakuljajan]

@bakuljajan, do you think you could add a test for this?

Thanks.

Hi @jamengual thanks for looking into this PR, I'm unfamiliar with writing golang code, but enabling the CustomPolicyCheck: true on the test already captures the error.

Let me know if you need me to add more test cases.

[chenrui333]

lgtm

[mubarak-j]

I think this part of the docs should be updated as well
custom policy tool output is simply parsed for "fail" substrings to determine if the policy set passed
to reflect that the custom policy check will fail if exit code !=0...which should be the expected default.

[bakuljajan]

I think this part of the docs should be updated as well custom policy tool output is simply parsed for "fail" substrings to determine if the policy set passed to reflect that the custom policy check will fail if exit code !=0...which should be the expected default.

I think the doc is correct since atlantis does check the string to determine the status for custom policy.

[X-Guardian]

@bakuljajan, can you resolve the file conflicts on this?

[X-Guardian]

LGTM