fix: Azure DevOps plan (issue 5507)#5611
Merged
chenrui333 merged 4 commits intorunatlantis:mainfrom Jun 26, 2025
Merged
Conversation
Fix issue described in drmaxgit/go-azuredevops#4 and in runatlantis#5507 Signed-off-by: bub3n <43008808+bub3n@users.noreply.github.com>
bub3n
changed the title
bub3n
changed the title
leonardocaylent
approved these changes
Jun 11, 2025
Contributor
leonardocaylent
left a comment
leonardocaylent
left a comment
There was a problem hiding this comment.
I tested this changes and the plans now trigger correctly for more than 100 files
Contributor
|
@bub3n I believe this is not needed anymore? I see only go.mod and sum updates. |
Contributor
|
@jamengual We still need this because main is at 0.13.1 https://github.com/runatlantis/atlantis/blob/main/go.mod#L13. I'm not familiar with the release process, do we get latest version available for packages automatically? |
Contributor
Author
|
@jamengual Sorry for delayed answer. I was out. If you will bump the version with renovate bot as mentioned here #5614. You can close it. Sorry did not realize that you are fixing the dependencies with renovate bot. |
jamengual
approved these changes
Jun 26, 2025
mowirth
pushed a commit
to mowirth/atlantis
that referenced
this pull request
Jun 27, 2025
Signed-off-by: bub3n <43008808+bub3n@users.noreply.github.com> Co-authored-by: Petr Bubenik <petr.bubenik@drmax.eu> Co-authored-by: PePe Amengual <2208324+jamengual@users.noreply.github.com> Signed-off-by: Moritz Wirth <mw@flanga.io>
dimisjim
pushed a commit
to dimisjim/atlantis
that referenced
this pull request
Oct 29, 2025
Signed-off-by: bub3n <43008808+bub3n@users.noreply.github.com> Co-authored-by: Petr Bubenik <petr.bubenik@drmax.eu> Co-authored-by: PePe Amengual <2208324+jamengual@users.noreply.github.com> Signed-off-by: dimisjim <dimitris.moraitidis@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
what
Fix for #5507
why
In the Atlantis GitHub issue #5507, there was a problem with downloading Git diff changes. The issue appeared after adding the top and skip arguments to the Git diff call. Previously, this endpoint did not return the changeCounts key when called with different arguments.
You can also see this in test scenario in
azuredevops/git_test.go(link) which does not reflect that. And if you compare it to the Azure Devops documentation it's missingchangeCountskey.To fix this, I updated the
GitCommitDiffsstruct by changing the key to a string type, aligning it with other structs withchangeCountskey for consistency.tests
make test-allwent thru without errors. And thanks to @leonardocaylent for testing the new build with the change in his environment.references