revert: "convert gopkg.in/yaml.v3 to goccy/go-yaml (#5579)"#5683
Merged
jamengual merged 3 commits intorunatlantis:mainfrom Jul 30, 2025
Merged
revert: "convert gopkg.in/yaml.v3 to goccy/go-yaml (#5579)"#5683jamengual merged 3 commits intorunatlantis:mainfrom
jamengual merged 3 commits intorunatlantis:mainfrom
Conversation
This reverts commit 8639729.
Contributor
Author
|
I’ll follow up with a separate PR to document our expected behavior around YAML anchors and aliases, and to add test coverage so we can better catch this in the future. |
mowirth
pushed a commit
to mowirth/atlantis
that referenced
this pull request
Jul 31, 2025
runatlantis#5683) Co-authored-by: PePe Amengual <2208324+jamengual@users.noreply.github.com> Signed-off-by: Moritz Wirth <mw@flanga.io>
mowirth
pushed a commit
to mowirth/atlantis
that referenced
this pull request
Jul 31, 2025
runatlantis#5683) Co-authored-by: PePe Amengual <2208324+jamengual@users.noreply.github.com> Signed-off-by: Moritz Wirth <mw@flanga.io>
ramonvermeulen
pushed a commit
to bschaatsbergen/atlantis
that referenced
this pull request
Oct 13, 2025
runatlantis#5683) Co-authored-by: PePe Amengual <2208324+jamengual@users.noreply.github.com> Signed-off-by: Ramon Vermeulen <ramonvermeulen98@gmail.com>
dimisjim
pushed a commit
to dimisjim/atlantis
that referenced
this pull request
Oct 29, 2025
runatlantis#5683) Co-authored-by: PePe Amengual <2208324+jamengual@users.noreply.github.com> Signed-off-by: dimisjim <dimitris.moraitidis@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR reverts the change introduced in #5579, which replaced
gopkg.in/yaml.v3withgithub.1485827954.workers.dev/goccy/go-yaml. The migration introduced stricter parsing rules that now rejectatlantis.yamlconfigurations using YAML anchors resulting in duplicate keys after resolution—configurations that previously worked in v0.34.0.While stricter validation has its benefits, this change broke backwards compatibility without being clearly communicated as a breaking change in the release notes. Given the number of users impacted and the ongoing discussion in #5665, this revert aims to: