Skip to content

revert: "convert gopkg.in/yaml.v3 to goccy/go-yaml (#5579)"#5683

Merged
jamengual merged 3 commits intorunatlantis:mainfrom
bschaatsbergen:r/revert-8639729
Jul 30, 2025
Merged

revert: "convert gopkg.in/yaml.v3 to goccy/go-yaml (#5579)"#5683
jamengual merged 3 commits intorunatlantis:mainfrom
bschaatsbergen:r/revert-8639729

Conversation

@bschaatsbergen
Copy link
Contributor

This PR reverts the change introduced in #5579, which replaced gopkg.in/yaml.v3 with github.com/goccy/go-yaml. The migration introduced stricter parsing rules that now reject atlantis.yaml configurations using YAML anchors resulting in duplicate keys after resolution—configurations that previously worked in v0.34.0.

While stricter validation has its benefits, this change broke backwards compatibility without being clearly communicated as a breaking change in the release notes. Given the number of users impacted and the ongoing discussion in #5665, this revert aims to:

  • Restore compatibility for users relying on YAML anchors
  • Prevent unnecessary rework across many end-user repositories
  • Give the community time to propose and discuss stricter parsing as an opt-in feature, hopefully upstream

@github-actions github-actions bot added dependencies PRs that update a dependency file go Pull requests that update Go code labels Jul 29, 2025
@bschaatsbergen bschaatsbergen changed the title Revert "chore(deps): Convert go yaml to goccy yaml (#5579)" revert: "convert gopkg.in/yaml.v3 to goccy/go-yaml (#5579)" Jul 29, 2025
@bschaatsbergen
Copy link
Contributor Author

I’ll follow up with a separate PR to document our expected behavior around YAML anchors and aliases, and to add test coverage so we can better catch this in the future.

@jamengual jamengual merged commit bcd6420 into runatlantis:main Jul 30, 2025
40 of 41 checks passed
@bschaatsbergen bschaatsbergen deleted the r/revert-8639729 branch July 31, 2025 00:24
mowirth pushed a commit to mowirth/atlantis that referenced this pull request Jul 31, 2025
runatlantis#5683)

Co-authored-by: PePe Amengual <2208324+jamengual@users.noreply.github.com>
Signed-off-by: Moritz Wirth <mw@flanga.io>
mowirth pushed a commit to mowirth/atlantis that referenced this pull request Jul 31, 2025
runatlantis#5683)

Co-authored-by: PePe Amengual <2208324+jamengual@users.noreply.github.com>
Signed-off-by: Moritz Wirth <mw@flanga.io>
ramonvermeulen pushed a commit to bschaatsbergen/atlantis that referenced this pull request Oct 13, 2025
runatlantis#5683)

Co-authored-by: PePe Amengual <2208324+jamengual@users.noreply.github.com>
Signed-off-by: Ramon Vermeulen <ramonvermeulen98@gmail.com>
dimisjim pushed a commit to dimisjim/atlantis that referenced this pull request Oct 29, 2025
runatlantis#5683)

Co-authored-by: PePe Amengual <2208324+jamengual@users.noreply.github.com>
Signed-off-by: dimisjim <dimitris.moraitidis@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies PRs that update a dependency file go Pull requests that update Go code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants