Remove boot class path #62
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I may have been unclear in my previous comment; my experience was that only the boot-classpath was used for the agent jar, and not the system classpath. I was unable to get it working without the boot classpath. |
Contributor
Author
|
Thanks a lot @Databean ! "I was unable to get it working without the boot classpath" - can you please clarify? We are able to build agents and run them in Windows and Linux, even after removing the boot classpath, so I am not sure what you meant. Thanks again. |
|
For Rv-Predict we've noticed that if our libraries are not in the bootclasspath and if the program uses multiple classloaders, then the agent might not be able to access those libraries. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am suppressing the code which adds the bootclasspath attribute to the generated agent's manifest.mf file. First, @Databean's experience (see his comments in #60) shows that the agent doesn't really need it. Second, according to this sun official document, that attribute is completely optional. Third, this is causing some unnecessary warnings to be generated in windows.
@pdaian, @Databean, @seriousamlqz, please review