Skip to content

Conversation

@seriousamlqz
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not an acceptable response to an IO exception. You should investigate what K is doing for errors and try to do something similar, so that users get a friendly error message in this case rather than a stack trace.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use a larger number in your editor to prevent few imports like this from being squashed together

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may want to add a comment here about the reason we added this patch, namely that build gets stuck, and explain the patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants